Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all linting issues in care #2483

Merged
merged 40 commits into from
Sep 24, 2024
Merged

Fix all linting issues in care #2483

merged 40 commits into from
Sep 24, 2024
+1,573 −2,019

Conversation

vigneshhari
Copy link
Member

Fix all linting issues in care

@vigneshhari vigneshhari requested a review from a team as a code owner September 22, 2024 11:34
@codecov Codecov
Copy link

codecov bot commented Sep 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.80225% with 465 lines in your changes missing coverage. Please review.

Project coverage is 65.59%. Comparing base (7478b9a) to head (2e83cb2).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...e/facility/api/serializers/patient_consultation.py 19.60% 34 Missing and 7 partials ⚠️
care/facility/api/serializers/file_upload.py 8.10% 31 Missing and 3 partials ⚠️
care/utils/ulid/ulid.py 40.90% 26 Missing ⚠️
care/users/api/serializers/user.py 17.39% 15 Missing and 4 partials ⚠️
care/facility/api/viewsets/patient.py 42.85% 11 Missing and 5 partials ⚠️
care/utils/notification_handler.py 23.80% 15 Missing and 1 partial ⚠️
care/facility/api/viewsets/inventory.py 6.66% 14 Missing ⚠️
care/facility/api/serializers/patient.py 43.47% 11 Missing and 2 partials ⚠️
care/facility/api/viewsets/shifting.py 7.69% 11 Missing and 1 partial ⚠️
care/facility/models/patient.py 47.36% 10 Missing ⚠️
... and 84 more
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2483      +/-   ##
===========================================
+ Coverage    65.49%   65.59%   +0.10%     
===========================================
  Files          222      223       +1     
  Lines        13267    13383     +116     
  Branches      1882     1855      -27     
===========================================
+ Hits          8689     8779      +90     
- Misses        4191     4218      +27     
+ Partials       387      386       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigneshhari vigneshhari changed the title Fix linting in docs Fix all linting issues in care Sep 23, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 23, 2024
View reviewed changes
config/authentication.py Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 23, 2024
View reviewed changes
care/facility/api/serializers/patient_otp.py Dismissed Show dismissed Hide dismissed
care/utils/sms/send_sms.py Fixed Show fixed Hide fixed
@sainak sainak mentioned this pull request Sep 24, 2024
Open
2 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 24, 2024
View reviewed changes
care/utils/sms/send_sms.py Dismissed Show dismissed Hide dismissed
@sainak sainak removed the blocked label Sep 24, 2024
@vigneshhari vigneshhari merged commit 663bf30 into develop Sep 24, 2024
8 of 9 checks passed
@vigneshhari vigneshhari deleted the vigneshhari/fix-all-linting branch September 24, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sainak sainak sainak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vigneshhari @sainak